Skip to content

feat(playstation): Always fetch dumps from tempest #104040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2025
Merged

feat(playstation): Always fetch dumps from tempest #104040

merged 3 commits into from
Nov 27, 2025

Conversation

@mujacica
Copy link
Contributor

@mujacica mujacica commented Nov 26, 2025 •
edited
Loading

  • Always fetch dumps from tempest

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 26, 2025
@mujacica mujacica changed the title feat(playstation): Always fetch dumps from tempest, forward config to relay feat(playstation): Always fetch dumps from tempest Nov 26, 2025
@mujacica mujacica marked this pull request as ready for review November 26, 2025 10:17
@mujacica mujacica requested a review from a team as a code owner November 26, 2025 10:17
Dav1dde
Dav1dde approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also remove the UI option in one go, so customers are not mislead by it.

@codecov
Copy link

codecov bot commented Nov 26, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
30044 1 30043 241
View the top 1 failed test(s) by shortest run time 
tests.sentry.core.endpoints.test_organization_index.OrganizationsCreateTest::test_valid_slugs
Stack Traces | 1.8s run time 
#x1B[1m#x1B[.../core/endpoints/test_organization_index.py#x1B[0m:190: in test_valid_slugs
    response = self.get_success_response(name=input_slug, slug=input_slug)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:628: in get_success_response
    assert_status_code(response, 200, 300)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:47: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (500, b'{"detail":"Internal Error","errorId":null}')#x1B[0m
#x1B[1m#x1B[31mE   assert 500 < 300#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mujacica mujacica force-pushed the fix/playstation-dumps branch from 61c015a to 7b6a8a6 Compare November 26, 2025 10:42
priscilawebdev
priscilawebdev reviewed Nov 27, 2025
View reviewed changes
@mujacica mujacica requested a review from a team as a code owner November 27, 2025 12:40
@mujacica mujacica force-pushed the fix/playstation-dumps branch from e402ac3 to beea39d Compare November 27, 2025 12:41
cursor[bot]
cursor bot reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Frontend still shows non-functional "Attach Dumps" toggle

The backend removes the tempestFetchDumps option from the API (no longer returned in responses or accepted in PUT requests), but the frontend in static/app/views/settings/project/tempest/configForm.tsx still renders an "Attach Dumps" toggle that references project.tempestFetchDumps. This leaves a non-functional UI control that users can interact with but that has no effect since dumps are now always fetched. The frontend form and types need to be updated to remove this setting.

src/sentry/core/endpoints/project_details.py#L136-L137

sentry/src/sentry/core/endpoints/project_details.py

Lines 136 to 137 in beea39d

"dynamicSamplingBiases",
"tempestFetchScreenshots",

src/sentry/api/serializers/models/project.py#L1119-L1123

sentry/src/sentry/api/serializers/models/project.py

Lines 1119 to 1123 in beea39d

if has_tempest_access(obj.organization):
data["tempestFetchScreenshots"] = attrs["options"].get(
"sentry:tempest_fetch_screenshots", False
)

Fix in Cursor Fix in Web

@mujacica mujacica merged commit 3388290 into master Nov 27, 2025
65 of 66 checks passed
@mujacica mujacica deleted the fix/playstation-dumps branch November 27, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priscilawebdev priscilawebdev priscilawebdev left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Dav1dde Dav1dde Dav1dde approved these changes

@vgrozdanic vgrozdanic vgrozdanic approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mujacica @Dav1dde @vgrozdanic @priscilawebdev